Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 - JAX ontology interface change #16

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Jan 28, 2025

It is still on the version 0.x range after all so can change rapidly.

Description

Fixed

  • Updated JAX Ontology API Term Interface

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do attempt to add a new HPO term to a patient form

Expected test outcome

  • Check that the term can be successfully added
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by DN
  • "Merge and deploy" approved by DN
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@dnil
Copy link
Collaborator Author

dnil commented Jan 28, 2025

Search is unchanged:
Screenshot 2025-01-28 at 16 15 30

But then the actual term fetch has a new returned interface:
❌ Before:
Screenshot 2025-01-28 at 16 15 36
✅ After:
Screenshot 2025-01-28 at 16 25 26

@dnil dnil merged commit 1510e58 into main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant