fix: resolve TypeError in AzureManager _generate_resource_group_name … #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all4code
previously approved these changes
Jan 26, 2024
mturetskii
force-pushed
the
fix/azure-rg-name-type-error
branch
from
f7db45b to
0cb7520
Compare
mturetskii
force-pushed
the
fix/azure-rg-name-type-error
branch
from
0cb7520 to
66445c9
Compare
all4code
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This fix addresses a critical issue in the
AzureManagerclass, where an over-reliance on internal variables was observed. Previously, in the absence of externally provided data, the methods attempted to utilize uninitialized internal variables, leading to aTypeError: 'NoneType' object is not subscriptable.To resolve this issue, optional container_name parameters have been introduced to several key methods, including
_generate_resource_group_nameand_generate_storage_account_name. This modification allows the methods to utilize either external data or data from the object's internal state. Now, if external data is not provided, the methods will default to using the value of the internal variableself.iac_backend_storage_container_name.