-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SES, fix: argocd rbac, ci policy #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergs-pci
commented
Feb 21, 2024
git config --global user.email "<GIT_USER_EMAIL>" | ||
git config --global user.name "<GIT_USER_NAME>" | ||
git config --global user.email "[email protected]" | ||
git config --global user.name "cgdevx-bot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtsarfin
I can't agree with these hardcoded values. BTW, it works for me with parameters
This reverts commit 33970b9. fix: platform/gitops-pipelines/delivery/clusters/cc-cluster/core-services/components/argo-workflows/cluster-workflow-templates/version-changer-cwft.yaml back
all4code
previously approved these changes
Feb 21, 2024
Enable workload bootstrap to generate service account role name for AWS workloads automatically, based on AWS account id and CG DevX cluster + workload configuration. This change should provide working K8s identity annotations without executing IaC.
* Terraform gitlab module * feat(cli): Improved CLI GitLab support (#45) Implemented GitLab support in the CLI for managing Terraform configurations, enhancing the tool's interoperability with various Git providers. This update includes: - Adjustment of preflight checks to refine the expected scope of user permissions, ensuring a secure and correct setup process. - Introduction of the <GIT_REQUIRED_PROVIDER> parameter in the main.tf for Git providers to adhere to Terraform's best practices. * feat: add parameterization for GitHub and GitLab provider versions - Implemented parameterization for required Terraform provider versions for both GitHub and GitLab, sourcing versions from CLI constants. - Added GitLab support for preparing environment variables for the VCS module, enhancing integration capabilities. --------- Co-authored-by: Turetskii Mikhail <[email protected]>
all4code
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add email sending functionality for AWS managed platform
Fix ArgoCD RBAC
Fix CI IAM policy
Change node type from t3.large to m5.large in AWS