feat: google cloud provider #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provider # Conflicts: # tools/poetry.lock # tools/pyproject.toml
…provider # Conflicts: # tools/pyproject.toml
Closed
all4code
previously approved these changes
Aug 15, 2024
| resource "google_kms_crypto_key" "vault_unseal_key" { | ||
| name = "vault-unseal" | ||
| key_ring = google_kms_key_ring.vault_key_ring.id | ||
| rotation_period = "100000s" |
There was a problem hiding this comment.
27.77 hours looks a bit strange to me. Couldn't we set it to 24h at least or follow AWS and Azure approach where it's 365d?
There was a problem hiding this comment.
We can't use 24h here, It must be greater than a day (ie, 86400).
| """ | ||
| Restrict access to cloud native terraform remote state storage | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Is there any possible way to protect state storage on GCP?
There was a problem hiding this comment.
Done. Found a way, it should work fine in our case.
tools/cli/commands/setup.py
Outdated
| @@ -1052,3 +1085,14 @@ def setup_param_validator(params: StateStore) -> bool: | |||
| return False | |||
|
|
|||
| return True | |||
|
|
|||
|
|
|||
| def get_dns_deployment_name_by_cloud_provider(cloud_provider) -> str: | |||
There was a problem hiding this comment.
It's a good candidate to go under cloud provider manager "interface"
There was a problem hiding this comment.
Done, moved to cloud manager class.
sergs-pci
previously approved these changes
Aug 16, 2024
…d implement GCP storage security hardening - Fixed comments for clarity and accuracy. - Added logic to check the installation of additional gcloud components. - Introduced typing annotations for better code clarity and robustness. - Generated and updated docstrings for all methods using reST style. - Implemented logic to enforce strict access control policies on GCP storage buckets.
…:CloudGeometry/cg-devx-core-private into feature/google-cloud-provider
all4code
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request introduces support for Google Cloud Platform (GCP), enabling our platform to leverage a wide range of cloud services provided by Google.