Allow VisualCeption to work with any module that inherits from WebDriver #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update with rebasing from master, there are fixed tests. |
|
@buresmi7 @mklepaczewski is it possible to merge this commit into master? It would be very helpful to have a generic check that any module which inherits from WebDriver is a valid one - I also have a project which uses WPWebDriver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation requires WebDriver module explicitly for VisualCeption to work. Unfortunately, this prevents modules like WpWebDriver from working with VisualCeption. Proposed change tries first to find WebDriver module, and if it fails to do so, it tries to use the first module that inherits from WebDriver.