Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elements hiding behavior for full screen shot #66

Merged

Conversation

mgerasimchuk
Copy link

No description provided.

According to dev requirements of hirak/prestissimo package
TimeComparisonCest.dontSeeVisualChanges.block2.png
TimeComparisonCest.dontSeeVisualChangesAndHideElement.hideTheBlock.png
@mgerasimchuk
Copy link
Author

I updated test files for the same reason like in commit: e69ace1

*because font width was not the same (I think it happened because of versions of software in Dockerfile, not strict)

Copy link
Collaborator

@buresmi7 buresmi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good work 👍

@buresmi7 buresmi7 merged commit 5ff7ad8 into Codeception:master Jan 11, 2021
@buresmi7 buresmi7 linked an issue Jan 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fullScreenShot silently disables $excludeElements
2 participants