Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/codeception-upgrade-to-v5 #78

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

ggiak
Copy link

@ggiak ggiak commented Jan 10, 2023

Following up to https://github.com/Codeception/Codeception/blob/5.0/src/Codeception/Module.php

This is the complete Pull request to support Codeception v5
as well as some restructuring quite few things for the project to make it compatible to php8
at the same time there are some structural changes on the project to better match with the rest of the codeception modules.

Introduced folder structure as follows:

src/Codeception

  • src/Codeception/Exception
  • src/Codeception/Module
  • src/Codeception/Report

Additionally this also includes:

  1. compatibility with php8.2
  2. compatibility with codeception 5.0
  3. phpunit 9.5
  4. Strict types
  5. composer json updates
  6. new module version (v5) to match with the parent one
  7. new docker image for php8
  8. Namespaces
  9. and more...

Testing

docker-compose up --abort-on-container-exit --build

Results:

image

@ggiak
Copy link
Author

ggiak commented Jan 10, 2023

@buresmi7, @Arhell

@koehnlein
Copy link

I fixed the automated test in another pull request: ggiak#3

I don't know how and if I can update this pull request directly. But maybe someone else could have a look.

@buresmi7
Copy link
Collaborator

I fixed the automated test in another pull request: ggiak#3

I don't know how and if I can update this pull request directly. But maybe someone else could have a look.

@ggiak should approve your PR

BTW, good job guys ;)

@buresmi7
Copy link
Collaborator

Should I squash this PR? this action probably remove @koehnlein as the author of part of the code, on the other hand there is 18 commits... what do you think @ggiak @koehnlein ?

@ggiak
Copy link
Author

ggiak commented Jan 20, 2023

@buresmi7 I am ok with it, though if @koehnlein wishes we can rebase interactively.

@koehnlein
Copy link

@buresmi7 @ggiak Beeing mentioned as contributor would be nice. But if it causes trouble, it's not necessary.

[4b5f547] feature/codeception-upgrade-to-v5 (#2)
Co-authored-by: koehnlein <[email protected]>
@ggiak ggiak force-pushed the master branch 3 times, most recently from 8053d15 to 4b1e5da Compare January 20, 2023 09:22
@ggiak
Copy link
Author

ggiak commented Jan 20, 2023

@buresmi7, @koehnlein, I rebased, left 1 commit with co-authored-by & commit hash.

This should do the trick :)

@koehnlein
Copy link

@buresmi7 @ggiak I'm not sure, if this works. But im fine with merging. I do not want to block this great improvement only because of the question, if I would be listed somewhere or not. 😄

@buresmi7 buresmi7 merged commit c5b02cd into Codeception:master Jan 20, 2023
GeorgiDrumev pushed a commit to 1FF/visualception that referenced this pull request Jun 19, 2024
[4b5f547] feature/codeception-upgrade-to-v5 (#2)
Co-authored-by: koehnlein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants