feat(signer): Add Dirk support #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Dirk remote signer by mapping requests received by the signer module to a Dirk gateway.
A new signer option (
Dirk) was added to theLocalandRemoteones. When this config is used, the signer module starts acting as an interface between Dirk and the client, in order to keep the API.As Dirk doesn't support ECDSA signatures, requests involving that schema return a HTTP 400 (Bad request) error. Also because of this, the
DA_COMMITexample module was slightly modified to be able to avoid ECDSA operations using the TOML config.It's worth to note that Dirk has a small bug where signing passing the public key instead of an account name is impossible. In order to test this (and later use it) changes on PR#75 on Dirk repo should be applied.
Close #17