-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added zlib to dev-shell to fix cargo nightly #2331
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Regarding the difference in error count: we can fix that in a later PR, actually good that we're able to run bacon
now
7101db4
to
8ea8a6e
Compare
Issue
Can't run things with cargo +nightly (i.e
SKIP_WASM_BUILD=1 bacon clippy -- --all --tests
)Additional Changes
Added zlib to dev-shell. Fix inspired by this
Concerns: bacon ran with
SKIP_WASM_BUILD=1 bacon clippy -- --all --tests
is reporting many things on main as errors with this fix, which does not match with CI (20 errors, 1918 warnings 😵💫 )Note, this is probably a naive fix - feel free to correct/roast