consensus, core, eth, miner, params: update istanbul engine #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this change compatible with existing Istanbul setups? I tried to run this with my existing Istanbul blockchain, and all validators seem to stop making blocks :) |
|
Yes, it should be. Do you start it with |
|
It did work when I started from scratch (with 7 nodes instead of 3). |
|
@tylobban @joelburget @patrickmn Can you take a look? Thanks! |
|
So does this have backwards compatibility issues or not? |
|
@patrickmn This PR was to add back the missing code from our original PR (#166). It contains some fixes as well as performance improvement. |
patrickmn
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update istanbul engine.