Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parseSharedStrings return optional value #122

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Resolves #121.

@MaxDesiatov MaxDesiatov added the breaking change Change that breaks API compatibility label Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #122 into main will decrease coverage by 0.28%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   97.34%   97.05%   -0.29%     
==========================================
  Files           8        9       +1     
  Lines         301      306       +5     
==========================================
+ Hits          293      297       +4     
- Misses          8        9       +1     
Impacted Files Coverage Δ
Sources/CoreXLSX/XLSXFile.swift 96.82% <85.71%> (-0.74%) ⬇️
Sources/CoreXLSX/Relationships.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825b061...4749e0f. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 4e0d1bf into main Sep 14, 2020
@MaxDesiatov MaxDesiatov deleted the optional-shared-strings branch September 14, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change that breaks API compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

archiveEntryNotFound error
1 participant