Fix amount prop update #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fczuardi
commented
May 31, 2018
fczuardi
commented
- closes Amount selector, value should change if the props value is update after mount #381
vNakamura
requested changes
May 31, 2018
| @@ -57,6 +57,10 @@ class AmountSelectors extends React.Component { | |||
| this.onChange(Math.min(value, this.props.max), this.updateDisplayValue); | |||
| }; | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| this.onChange(nextProps.value, this.updateDisplayValue); | |||
There was a problem hiding this comment.
Can't this cause an infinite loop if props.onChange updates props.value?
Also, componentWillReceiveProps will be deprecated in React 17. Let's avoid using it for new code:
https://reactjs.org/blog/2018/03/29/react-v-16-3.html#component-lifecycle-changes
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
There was a problem hiding this comment.
regarding the possible loop, a listener for a value change that also immediately sets the value feels wrong, but anyways, the existing component(webapp) dont trigger an onChange, so I guess it is ok if we dont trigger one as well, I will just update state without calling the change handlers.
fczuardi
force-pushed
the
fix-amount-prop-update
branch
from
175558f to
db16d39
Compare
alcferreira
approved these changes
Jun 15, 2018
affects: @crave/farmblocks-amount-selectors
affects: @crave/farmblocks-amount-selectors
… mount affects: @crave/farmblocks-amount-selectors
affects: @crave/farmblocks-amount-selectors
alcferreira
force-pushed
the
fix-amount-prop-update
branch
from
db16d39 to
29be50c
Compare
vNakamura
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.