Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template for pull requests #401

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Template for pull requests #401

merged 2 commits into from
Jun 18, 2018

Conversation

fczuardi
Copy link
Contributor

Closes Issues

Code review checklist

Reviewer 1

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

Reviewer 2

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

@vNakamura vNakamura merged commit d196f55 into master Jun 18, 2018
@vNakamura vNakamura deleted the github-templates branch June 18, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vNakamura vNakamura vNakamura approved these changes

@alcferreira alcferreira alcferreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fczuardi @vNakamura @alcferreira