Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub releases #402

Merged
merged 4 commits into from
Jun 21, 2018
Merged

GitHub releases #402

merged 4 commits into from
Jun 21, 2018

Conversation

fczuardi
Copy link
Contributor

@fczuardi fczuardi commented Jun 19, 2018

Testing this can be challenging, the real test with travis will require github pushing and merging...

However, testing the 2 bash scripts individually is something possible, just create a Github draft release named "master" and run each script to check if it is working.

They rely on having jq installed, and this is something that I believe Travis has.

Closes Issues

Code review checklist

Reviewer 1

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

Reviewer 2

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

@fczuardi fczuardi force-pushed the github-releases branch 2 times, most recently from d5b210b to d601a80 Compare June 19, 2018 17:19
@fczuardi
Copy link
Contributor Author

The travis flow was tested on this PR #407 against a test branch. The travis report is here https://travis-ci.org/CraveFood/farmblocks/builds/394211046

Before:
image

During:
screenshot from 2018-06-19 14-41-08

After:
image 1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c04ef9f on github-releases into c7e5e34 on master.

fczuardi added 4 commits June 21, 2018 17:50
…ase ID

query github API for existing releases named master, parse it with jq and store the id in an env var
called RELEASE_ID
… release to false

given 2 env vars RELEASE_ID and GH_TOKEN, this script will rename the release to a name based on the
date, and release it (change draft status to false)
@fczuardi fczuardi merged commit 8d32087 into master Jun 21, 2018
@fczuardi fczuardi deleted the github-releases branch June 21, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants