Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SearchField getDerivedStateFromProps #405

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Fix SearchField getDerivedStateFromProps #405

merged 3 commits into from
Jun 19, 2018

Conversation

vNakamura
Copy link
Member

Closes Issues

Code review checklist

Reviewer 1

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

Reviewer 2

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

vNakamura added 3 commits June 19, 2018 13:47
@vNakamura
test(search-field): add tests for items prop change
2fdf05b 
affects: @crave/farmblocks-search-field
@vNakamura
fix(search-field): update selectedItem state when items prop changes
9297d87 
affects: @crave/farmblocks-search-field

ISSUES CLOSED: #404
@vNakamura
chore(storyshots): update
093723b 
affects: @crave/farmblocks-search-field
@vNakamura vNakamura merged commit d943481 into master Jun 19, 2018
@vNakamura vNakamura deleted the fix-search-item-changes branch June 19, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgameiro fgameiro fgameiro approved these changes

@alcferreira alcferreira alcferreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vNakamura @fgameiro @alcferreira