Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amount selector should truncate values on blur #410

Merged
merged 4 commits into from
Jun 20, 2018
Merged

Amount selector should truncate values on blur #410

merged 4 commits into from
Jun 20, 2018

Conversation

alcferreira
Copy link
Contributor

Closes Issues

Code review checklist

Reviewer 1

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

Reviewer 2

  • Functions properly
  • Good readability, clarity and overall quality
  • Has tests
  • Has docs

@alcferreira
fix(AmountSelector): fix initial render
8c0fe49 
affects: @crave/farmblocks-amount-selectors

number wasn't being formatted on the first render

ISSUES CLOSED: #409
@alcferreira
fix(AmountSelectors): send value with 2 decimal places
83d1ca9 
affects: @crave/farmblocks-amount-selectors

ISSUES CLOSED: #409
@alcferreira
test(snapshots): update
718793e 
affects: @crave/farmblocks-amount-selectors
@alcferreira
test(AmountSelectors): add test case to validate values with 2 decima…
5d1d8c4 
…l places

affects: @crave/farmblocks-amount-selectors
@alcferreira alcferreira changed the title [WIP] Amount selector should truncate values on blur Amount selector should truncate values on blur Jun 20, 2018
@fgameiro fgameiro merged commit 5c89321 into master Jun 20, 2018
@fgameiro fgameiro deleted the fix-amount-selector branch June 20, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fczuardi fczuardi fczuardi approved these changes

@fgameiro fgameiro fgameiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcferreira @fczuardi @fgameiro