Skip to content

Commit

Permalink
Merge duplicate meta types
Browse files Browse the repository at this point in the history
Remove some of the types introduced in swagger recently, as those are same
morphologically but differ in nomenclature. This avoids certain inconveniences
of strictly typed languages that distinguish the same types when registered
under a different name.
  • Loading branch information
isimluk committed Jul 26, 2022
1 parent 176f658 commit 48cdd9f
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 296 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion falcon/models/msa_query_response.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

188 changes: 0 additions & 188 deletions falcon/models/msaspec_meta_info.go

This file was deleted.

105 changes: 0 additions & 105 deletions falcon/models/msaspec_paging.go

This file was deleted.

2 changes: 1 addition & 1 deletion falcon/models/msaspec_response_fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions specs/transformation.jq
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
| .definitions."domain.DiscoverAPIHostEntitiesResponse".properties.errors.items."$ref" = "#/definitions/msa.APIError"
| .definitions."msa.QueryResponse".properties.errors.items."$ref" = "#/definitions/msa.APIError"
| .definitions."msaspec.ResponseFields".properties.errors.items."$ref" = "#/definitions/msa.APIError"
# Rename msaspec.Paging to msa.Paging. These are two names for the same type.
| del(.definitions."msaspec.Paging")
# Rename msaspec.MetaInfo to msa.MetaInfo. These are two names for the same type.
| del(.definitions."msaspec.MetaInfo")
| .definitions."domain.DiscoverAPIHostEntitiesResponse".properties.meta."$ref" = "#/definitions/msa.MetaInfo"
| .definitions."msa.QueryResponse".properties.meta."$ref" = "#/definitions/msa.MetaInfo"
| .definitions."msaspec.ResponseFields".properties.meta."$ref" = "#/definitions/msa.MetaInfo"
# Misc fixes
| .paths."/intel/entities/rules-latest-files/v1".get.parameters |= . + [{type: "string", description: "Download Only if changed since", name: "If-Modified-Since", "in": "header"}]
| .paths."/intel/entities/rules-latest-files/v1".get.responses."304" = {description: "Not Modified"}
Expand Down

0 comments on commit 48cdd9f

Please sign in to comment.