-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cargo]: Incorrect version number parsing in cargo.toml #1592
Comments
We introduced a toml library quite late to the project, so there is a lot of code that is parsing the toml files manually. Line 7465 in cd77efa
I think it is a good idea to refactor all cargo parsing methods to use toml library. Would you be interested in contributing a PR? |
@prabhu Thank you for the invitation, this is indeed a good idea. I will try to complete it, and if I can do it well, I will submit a PR. |
…oneDX#1592) Signed-off-by: Lizhe Lv <[email protected]>
…oneDX#1592) Signed-off-by: Lizhe Lv <[email protected]>
…oneDX#1592) Signed-off-by: Lizhe Lv <[email protected]>
Signed-off-by: Lizhe Lv <[email protected]>
…oneDX#1592) Signed-off-by: Lizhe Lv <[email protected]>
… (#1595) * Refactor toml and lock file in cargo parsing using `@iarna/toml`(#1592) Signed-off-by: Lizhe Lv <[email protected]> * Optimize cargo dependencies parsing Signed-off-by: Lizhe Lv <[email protected]> * lint Signed-off-by: Prabhu Subramanian <[email protected]> * Bug fix Signed-off-by: Prabhu Subramanian <[email protected]> --------- Signed-off-by: Lizhe Lv <[email protected]> Signed-off-by: Prabhu Subramanian <[email protected]> Co-authored-by: Prabhu Subramanian <[email protected]>
Case
Issue Description
In the provided
cargo.toml
file, the version number for the dependencyserde_json
is specified as1.0.128 }
The text was updated successfully, but these errors were encountered: