Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Moved the example to the correct EnvVar #1338

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[Documentation] Moved the example to the correct EnvVar #1338

merged 2 commits into from
Sep 2, 2024

Conversation

malice00
Copy link
Collaborator

The example used at GRADLE_ARGS can't actually be used there and should be at GRADLE_ARGS_DEPENDENCIES.

@malice00 malice00 requested a review from prabhu as a code owner August 28, 2024 22:42
@prabhu
Copy link
Collaborator

prabhu commented Aug 29, 2024

Can you please elaborate why it can't be used in GRADLE_ARGS?

@malice00
Copy link
Collaborator Author

Because it is a parameter specific to the dependencies task. Adding it in the GRADLE_ARGS parameter, will make the properties task fail.

@prabhu
Copy link
Collaborator

prabhu commented Aug 29, 2024

Since it is a readme, is there any other example we can add that is common for both properties and dependencies task?

@malice00
Copy link
Collaborator Author

Sure, maybe a good example would be '--init-script some-file.gradle', '--max-workers' or '--no-parallel' -- although I am not sure if the latter 2 would make much sense when not using GRADLE_MULTI_THREADED.
Shall I add one/all of those?

@prabhu prabhu merged commit 288aef0 into CycloneDX:master Sep 2, 2024
12 of 13 checks passed
@malice00 malice00 deleted the fix/docs branch September 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants