Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to create root component in metadata when data: URLs present #45

Closed
officerNordberg opened this issue Apr 20, 2022 · 0 comments · Fixed by #46
Closed

Fails to create root component in metadata when data: URLs present #45

officerNordberg opened this issue Apr 20, 2022 · 0 comments · Fixed by #46
Labels
bug Something isn't working

Comments

@officerNordberg
Copy link
Contributor

dependencyPkg = await readPkgUp({cwd: dependency});

dependency = "data:image/svg+xml;charset=utf-8,<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"16\" height=\"15\" aria-hidden=\"true\"><path fill=\"%23fff\" fill-rule=\"evenodd\" d=\"M4 12h4v1H4v-1zm5-6H4v1h5V6zm2 3V7l-3 3 3 3v-2h5V9h-5zM6.5 8H4v1h2.5V8zM4 11h2.5v-1H4v1zm9 1h1v2c-.02.28-.11.52-.3.7-.19.18-.42.28-.7.3H3c-.55 0-1-.45-1-1V3c0-.55.45-1 1-1h3c0-1.11.89-2 2-2 1.11 0 2 .89 2 2h3c.55 0 1 .45 1 1v5h-1V5H3v9h10v-2zM4 4h8c0-.55-.45-1-1-1h-1c-.55 0-1-.45-1-1s-.45-1-1-1-1 .45-1 1-.45 1-1 1H5c-.55 0-1 .45-1 1z\"/></svg>"
read-pkg-up simply chips away at this string until it arrives at the root package.json, the logic then creates an inverse depenency relationship that does not exist and increments the root project for as many data: urls are resolved.

"metadata": { "timestamp": "2022-04-20T01:17:38.978Z", "tools": [ { "vendor": "CycloneDX", "name": "webpack-plugin", "version": "1.0.1" } ] },

@jkowalleck jkowalleck added the bug Something isn't working label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants