Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude data: urls #46

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

officerNordberg
Copy link
Contributor

@officerNordberg officerNordberg commented Apr 20, 2022

fixes #45

@officerNordberg officerNordberg requested a review from a team as a code owner April 20, 2022 03:20
@jkowalleck
Copy link
Member

Thanks for the pull request, @officerNordberg .

To indicate that you agree to publish your work under the license of this project,
please sign your commit(s).
See https://github.com/CycloneDX/cyclonedx-webpack-plugin/pull/46/checks?check_run_id=6088607933

@jkowalleck jkowalleck changed the title Bugfix/issue 45 not add data: urls Apr 20, 2022
@jkowalleck jkowalleck changed the title not add data: urls exclude data: urls Apr 20, 2022
drew-sw added 4 commits April 20, 2022 08:56
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
This reverts commit 68dc516.

Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
@jkowalleck jkowalleck merged commit 5604228 into CycloneDX:master Apr 22, 2022
@jkowalleck
Copy link
Member

@officerNordberg i see that this project is lacking integration tests.
Could you help and provide a small example project/setup, that uses yclonedx-webpack-plugin ?
I would create an integration test from that example, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to create root component in metadata when data: URLs present
3 participants