XML parser #4180
Merged
XML parser #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ree and manage node as arrays
…ssue with ES6 syntax
…nodes as array process) on-the-fly
…at can contain a number value (such as "id" attribute)
…h.js into feature/xml-parser
Closed
dsilhavy
requested changes
Jun 21, 2023
| import ObjectIron from './objectiron'; | ||
| import X2JS from '../../../externals/xml2json'; |
There was a problem hiding this comment.
Remove xml2json from externals folder
| const acc = new DescriptorType(); | ||
| return acc.init(audioChanCfg); | ||
| }); | ||
| } | ||
|
|
||
| function getAudioChannelConfigurationForRepresentation(representation) { | ||
| if (!representation || !representation.hasOwnProperty(DashConstants.AUDIOCHANNELCONFIGURATION_ASARRAY) || !representation[DashConstants.AUDIOCHANNELCONFIGURATION_ASARRAY].length) return []; | ||
| return representation[DashConstants.AUDIOCHANNELCONFIGURATION_ASARRAY].map( audioChanCfg => { | ||
| if (!representation || !representation.hasOwnProperty(DashConstants.AUDIO_CHANNEL_CONFIGURATION) || !representation[DashConstants.AUDIO_CHANNEL_CONFIGURATION].length) return []; |
There was a problem hiding this comment.
Function is defined two times, probably a merge mistake
There was a problem hiding this comment.
Yes indeed, a merge mistake
| constructor() { | ||
| super( | ||
| (attr, nodeName) => { | ||
| const stringAttrsInElements = { |
There was a problem hiding this comment.
Is this per default always converted to string which is why we dont need this matcher anymore?
|
Fixed, InbandEventStream was not in the list of nodes being represented as an array |
|
This XML parser does not handle escape sequences correctly. As a result, urls containing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3412
The goal of this PR is to provide a new XML parser in order to speed up parsing time.
Parsing time may be criticial for long contents with SegmentTimelines.
What has been achieved in this PR:
Here are some numbers for the XML parsing processing time (in ms) for a 240mn content having one AdaptationSet with a SegmentTimeline without repeat pattern: