-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] CommonMediaRequest #4299
Merged
Merged
[v5] CommonMediaRequest #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse API - use CommonMediaRequest and CommonMediaResponse as base types for processing requests and responses - apply request and response plugins - mutualize RequestModifier usage in HTTPLoader and apply RequestModifier before request plugins - update CmsdModel since response headers are now returned as a record of key:value
- rename Request/ResponsePlugin to Request/ResponseInterceptor - Request/ResponseInterceptor resolve Promise with returned request/response - rename sample request-plugin to network-interceptor
- HTTLoader.load returned a Promise resolved once the inner loader (e.g. XHR) is loaded in order to get the XMLHttpRequest
- HTTLoader.load returned a Promise resolved once the inner loader (e.g. XHR) is loaded in order to get the XMLHttpRequest
dsilhavy
requested changes
Nov 22, 2023
dsilhavy
requested changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the
CommonMediaRequest
andCommonMediaResponse
API from SVTA CommonMediaLibrary, available from version 0.5.0, to make dash.js relying on this reference API to enable applications to intercept requests and responses and to read stats/metrics of all requests.See issue #4152
Pull request on SVTA Github to include
CommonMediaRequest
andCommonMediaResponse
API : streaming-video-technology-alliance/common-media-library#18What has been done so far:
HTTPLoader
,XHRLoader
andFetchLoader
to relyCommonMediaRequest
andCommonMediaResponse
HTTPLoader
To test the sample:
samples/network-interceptor
npm install
thennpm run build
localhost:3000/samples/network-interceptor/index.html
(oncenpm start
is running on project)What remains to be done:
CommonMediaRequest
andCommonMediaResponse
if neededRequestModifier
API! Note:
Npm package
@svta/common-media-library
declared in package.json does not integrate yet therequest
package.To enable building and sample running, you need:
@svta/common-media-library
common-media-request
dist
files intonode_modules/@svta/common-media-library
and intosamples/network-interceptor/node_modules/@svta/common-media-library