Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.23 with latest golangci-lint #906

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

ptnapoleon
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 11, 2024

Datadog Report

Branch report: philip/new-go
Commit report: 5257fb8
Test service: chaos-controller

✅ 0 Failed, 970 Passed, 2 Skipped, 12m 1.85s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • [It] Disruption Client List Method should list disruptions correctly when there are three disruptions in the cluster - Controller Suite - Last Failure

    Expand for error
     A node timeout occurred
     
     [TIMEDOUT] A node timeout occurred
     In [It] at: /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/clientset_test.go:149 @ 09/11/24 18:01:32.872
     
     This is the Progress Report generated when the node timeout occurred:
       Disruption Client List Method should list disruptions correctly when there are three disruptions in the cluster (Spec Runtime: 2m21.164s)
         /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/clientset_test.go:149
         In [It] (Node Runtime: 30s)
           /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/clientset_test.go:149
     ...
    

@ptnapoleon ptnapoleon marked this pull request as ready for review September 11, 2024 18:54
@ptnapoleon ptnapoleon requested a review from a team as a code owner September 11, 2024 18:54
Copy link
Contributor

@aymericDD aymericDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼 🧽 🪄

@ptnapoleon ptnapoleon merged commit 3a914e9 into main Sep 12, 2024
18 checks passed
@ptnapoleon ptnapoleon deleted the philip/new-go branch September 12, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants