Process monitoring with grouping support #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| except psutil.NoSuchProcess: | ||
| pass | ||
| #Return value in KB | ||
| return (rss, vms) |
There was a problem hiding this comment.
You want to return memory in bytes, not KB here.
There was a problem hiding this comment.
On MacOSX, this returns a value in bytes already.
|
@mastrolinux we pull this data already (see treemap on the host dashboards) but I don't think we have an easy way to turn these into data that can be queried easily. I've added a few comments to your pull request. |
| if name == 'All': | ||
| process = ['All'] | ||
| search_string = instance.get('search_string') | ||
| pids_list = self.process_finder(process, search_string) |
There was a problem hiding this comment.
surround the whole block with
try:
# ...
except Exception, e:
self.log.debug("Cannot extract process data: %s" % str(e))
|
@MisterRayCo we're taking a stab at it. |
|
@alq666 As a general purpose feel free to directly change my code since I am not a developer. I'll try to fix the code with your nice suggestions but I will not have much time to do it in the near future. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires psutil and works on: Linux, Windows, OSX and FreeBSD, both 32-bit and 64-bit.