feat: Change default tracing headers #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default tracing headers to use both Datadog's format as well as the W3C tracecontext header types. refs: RUM-1557
0xnm
previously approved these changes
Oct 25, 2023
ganeshnj
reviewed
Oct 25, 2023
| @@ -247,7 +247,11 @@ void main() { | |||
|
|
|||
| expect(datadogSdk.firstPartyHosts.length, 2); | |||
| expect(datadogSdk.firstPartyHosts[0].hostName, 'example.com'); | |||
| expect(datadogSdk.firstPartyHosts[0].headerTypes, | |||
| {TracingHeaderType.datadog, TracingHeaderType.tracecontext}); | |||
There was a problem hiding this comment.
can you also assert the data in both headers (datadog and tracecontext) is same?
if this is covered somewhere else, I'm fine with that also.
There was a problem hiding this comment.
👍 I actually thought I had it in the actual tracing library, but it appears not. I'll add it.
There was a problem hiding this comment.
Added for the main library. Ready for re-review.
fuzzybinary
force-pushed
the
jward/RUM-1557-default-tracecontext
branch
2 times, most recently
from
056daf0 to
dc2feb7
Compare
xgouchet
approved these changes
Oct 26, 2023
ganeshnj
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Change the default tracing headers to use both Datadog's format as well as the W3C tracecontext header types.
refs: RUM-1557
Review checklist
CI Configuration (optional)