Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Device Model, No Type #1489

Closed
ls-clark-yin opened this issue Sep 20, 2023 · 9 comments · Fixed by #1672
Closed

iOS Device Model, No Type #1489

ls-clark-yin opened this issue Sep 20, 2023 · 9 comments · Fixed by #1672
Assignees

Comments

@ls-clark-yin
Copy link

Lack of Device Type

Currently, is there a way to get the device model type?

like iPad Pro, iPad Air etc? I only see "iPad" and i am trying to recreate the panel from new relic we currently have. I Know i can implement it on our-side but is there a way to differentiate on DD that i'm missing? Thanks.

image
@ncreated
Copy link
Member

ncreated commented Sep 20, 2023

Hello @ls-clark-yin 👋. What you're looking for is device.model:

Screenshot 2023-09-20 at 17 49 34

Simply, aggregate by device.model 👇 and display it as "Pie Chart".

Screenshot 2023-09-20 at 17 51 42

Let us know if this helps.

@ncreated ncreated self-assigned this Sep 20, 2023
@ncreated ncreated added the question Further information is requested label Sep 20, 2023
@ls-clark-yin
Copy link
Author

Hello @ls-clark-yin 👋. What you're looking for is device.model:

Screenshot 2023-09-20 at 17 49 34 Simply, aggregate by `device.model` 👇 and display it as "Pie Chart". Screenshot 2023-09-20 at 17 51 42 Let us know if this helps.

Thanks for the quick reply i don't have those facet and only see iPad under what i believe is the same place for my logs. am i missing something in terms of implementing my logger? I am currently running on simulator as well, i think that shouldn't be an issue but let me know if it is.

image

@ls-clark-yin
Copy link
Author

@ncreated Let me know if i need to provide more information on how logger was setup thank you!

@ncreated
Copy link
Member

@ls-clark-yin What I explained is for RUM, didn't know you refer to Logs 🙂. Indeed, I acknowledge the problem: we need to improve device info in log events. We will work on this on our side and keep this issue updated.

Meantime, you may want to send this information manually and create facets by your own. You can configure it globally for all events with logger.addAttribute(forKey:value:).

@ncreated ncreated added enhancement and removed question Further information is requested labels Sep 21, 2023
@ls-clark-yin
Copy link
Author

Got it, sorry for the confusion, so if we use Logs exclusively we will need to orchestrate it on our side but if we use RUM it should be working, i'll try that out thanks.

@ls-clark-yin
Copy link
Author

Is there any timeline for the facets for logs? Thanks

@aldoKelvianto
Copy link

Hi @ls-clark-yin @ncreated I've made a PR to address this in here #1672

Please let me know whether this is what you've expected or not.

Thank you

@ls-clark-yin
Copy link
Author

Hi @ls-clark-yin @ncreated I've made a PR to address this in here #1672

Please let me know whether this is what you've expected or not.

Thank you

Yes! thank you for working on this, this looks correct, once it's up i'll make a ticket to add it and see if it's as expected. Thank you!

@ncreated
Copy link
Member

ncreated commented Mar 6, 2024

@aldoKelvianto Thanks for contribution 👍. It is now merged, expect this to be available in next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants