-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatadogLogs - Add Device's Brand, Name, and Model in LogEvent
#1672
DatadogLogs - Add Device's Brand, Name, and Model in LogEvent
#1672
Conversation
Thanks for the contribution @aldoKelvianto Could you please run linter, because it's failing on CI? You can find more info under In the meantime I'll try to evaluate validity of your proposal and let you know. We have some internal action plan regarding this, and we need to make sure it's aligned. |
Thank you so much for sharing the solution, I'll run the linter and try the CI again 🙏
Sure thing, thank you! |
Enabled CI |
@aldoKelvianto great contribution, thank you! I made necessary updates for lint and tests and we will follow with a merge. @DataDog/rum-mobile-ios All tests are green. CI failed on dependency-manager tests as MacCatalyst build doesn't support fork branches. This is false-positive, I will proceed with elevated permission merge. |
squashed and signed
ce8f5a4
to
cd60e99
Compare
What and why?
In the current logging implementation, we haven't automatically include device's brand, name, and model.
It is possible to add it manually by adding
device-model
in Global Attributes, as mentioned in this doc: https://docs.datadoghq.com/logs/log_collection/ios/?tab=cocoapods#global-attributesHowever, as user in #1489 mentioned, it would be nice if the SDK add the device's model automatically.
Resolve #1489
How?
A brief description of implementation details of this PR.
Review checklist
Custom CI job configuration (optional)
tools/