Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork of opentelemetry-swift is out of date #2190

Closed
jbluntz opened this issue Feb 11, 2025 · 12 comments
Closed

Fork of opentelemetry-swift is out of date #2190

jbluntz opened this issue Feb 11, 2025 · 12 comments

Comments

@jbluntz
Copy link

jbluntz commented Feb 11, 2025

Are there any plans to update http://github.com/datadog/opentelemetry-swift-packages to the latest in upstream, and update the dependency here? There are a few notable additions that we'd really like to take advantage of, including swift concurrency support (with TaskLocalContextManager) and closure-based APIs for starting and activating spans.

@ncreated
Copy link
Member

Hey @jbluntz 👋. That's a fair point - we created a backlog item for this and the upgrade will happen soon. Can't promise any ETA at this moment, but we will keep this thread updated. Please stay tuned 🙏.

@calebhearth
Copy link

@ncreated It also appears to no longer compile under Xcode 16.3.0-beta due to the Span extension for == not including Self as one of the types

Member operator '==' of protocol 'Span' must have at least one argument of type 'Self'

That's resolved on the main branch as well as upstream.

@maxep
Copy link
Member

maxep commented Feb 24, 2025

Hey @calebhearth 👋

Thanks for the report, we will update the otel dependency soon. We will keep you posted.

@cameroncooke
Copy link

My project now won't compile due to a compiler issue in the older version of opentelemetry-swift that Datadog utilises. Do we have a timescale for a fix?

@maxep
Copy link
Member

maxep commented Feb 27, 2025

Hey @cameroncooke,

Can you confirm that it fails to compile on Xcode 16.3 Beta only ?
It should build properly on Xcode 16.2

We are actively working on this and we should be able to release a fix in the coming weeks.
Sorry for the inconvenience.

@cameroncooke
Copy link

cameroncooke commented Feb 27, 2025 via email

@jbluntz
Copy link
Author

jbluntz commented Feb 27, 2025

@maxep can I ask if it's possible to include a podspec for the Concurrency target in the update? I noticed yesterday that it is accessible via SPM but not cocoapods...

@maxep
Copy link
Member

maxep commented Feb 27, 2025

Hey @jbluntz 👋

What Concurrency target? I don't see any in the Package.swift 🤔

@jbluntz
Copy link
Author

jbluntz commented Feb 27, 2025

@maxep
Copy link
Member

maxep commented Feb 27, 2025

Ah, I see! we will focus on shipping the otel-swift 1.13 API first and fix the build. We will then look at adding the concurrency extension. Thanks for pointing this 👍

@ncreated
Copy link
Member

ncreated commented Mar 5, 2025

Hey everyone! 👋

We've just merged the upgrade to 1.13.0 (#2217), and it will be included in the next SDK release, planned for the coming days.

can I ask if it's possible to include a podspec for the Concurrency target in the update? I noticed yesterday that it is accessible via SPM but not cocoapods...

@jbluntz This won’t be part of the upcoming release, but we’ll explore bundling OpenTelemetryConcurrency in the future. I’ve added this to our backlog, though I can't provide an ETA nor priority at this time.

We'll close this issue once the update is released. Thanks for your input! 🚀

@ncreated
Copy link
Member

ncreated commented Mar 6, 2025

2.24.0 is now available and it includes OTel Api 1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants