Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RUM Schema #1247

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Update RUM Schema #1247

merged 1 commit into from
Apr 13, 2023

Conversation

fuzzybinary
Copy link
Member

What and why?

Update the RUM schema to latest, which moves session.isActive to only report on View updates and adds session.startReason

I'm setting session.startReason to nil for now and we'll revisit when we actually add that feature.

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@fuzzybinary
Update RUM Schema
2bb902e 
Move session.isActive to only report on View updates. Add session.startReason (nil for now)
@fuzzybinary fuzzybinary requested a review from a team as a code owner April 13, 2023 14:09
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 13, 2023 •
edited
Loading

Datadog Report

Branch report: jward/schema-update
Commit report: 2bb902e

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 2108 Passed, 0 Skipped, 6m 12.01s Wall Time

maxep
maxep approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fuzzybinary!

@fuzzybinary fuzzybinary merged commit 6beacd7 into develop Apr 13, 2023
@fuzzybinary fuzzybinary deleted the jward/schema-update branch April 13, 2023 18:07
@maciejburda maciejburda mentioned this pull request Apr 19, 2023
Merged
@maxep maxep mentioned this pull request May 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzybinary @maxep