Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-3349 Add context to crash when there's an active view #1315

Merged
merged 1 commit into from
Jun 26, 2023
Merged

RUMM-3349 Add context to crash when there's an active view #1315

merged 1 commit into from
Jun 26, 2023

Conversation

plousada
Copy link
Member

What and why?

We're currently not reporting user set global attributes when collecting a crash.
This PR addresses this.

How?

Context reported on the RUM Error created when collecting a crash is extracted from the last active RUM View.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@plousada plousada requested a review from a team as a code owner June 20, 2023 11:10
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 20, 2023 •
edited
Loading

Datadog Report

Branch report: plousada/RUMM-3349/add-rum-context-to-crash
Commit report: 180ccd9

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 116 Passed, 0 Skipped, 3m 42s Wall Time

@plousada plousada force-pushed the plousada/RUMM-3349/add-rum-context-to-crash branch from 2b9ab68 to f48bf7c Compare June 26, 2023 09:36
ncreated
ncreated approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one suggestion, looks good 👍

maxep
maxep approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've left a small suggestion.

@plousada plousada force-pushed the plousada/RUMM-3349/add-rum-context-to-crash branch from f48bf7c to 180ccd9 Compare June 26, 2023 13:01
@plousada plousada merged commit 73e99dd into develop Jun 26, 2023
@maciejburda maciejburda deleted the plousada/RUMM-3349/add-rum-context-to-crash branch June 26, 2023 14:01
@maciejburda maciejburda mentioned this pull request Jun 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

@maxep maxep maxep approved these changes

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plousada @ncreated @maxep @maciejburda