Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-456 Add privacy manifest #1644

Merged
merged 3 commits into from
Jan 24, 2024
Merged

RUM-456 Add privacy manifest #1644

merged 3 commits into from
Jan 24, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Jan 23, 2024

What and why?

Add privacy manifest describing use of required reason API.

This manifest only covers APIs, not data collected.

resolve #1406

How?

Add privacy manifest to DatadogCore which is the only module making use of required apis:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep self-assigned this Jan 23, 2024
@maxep maxep requested review from a team as code owners January 23, 2024 16:44
ncreated
ncreated previously approved these changes Jan 24, 2024
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good 👍. Let's link #1406 to this PR 🙂.

@maxep maxep force-pushed the maxep/RUM-456/privacy-manifest branch from dd620d6 to 9faa46c Compare January 24, 2024 09:19
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 24, 2024

Datadog Report

Branch report: maxep/RUM-456/privacy-manifest
Commit report: 9faa46c
Test service: dd-sdk-ios

✅ 0 Failed, 2743 Passed, 0 Skipped, 11m 9.55s Wall Time
🔻 Test Sessions change in coverage: 11 decreased, 3 increased

🔻 Code Coverage Decreases vs Default Branch (11)

This report shows up to 5 code coverage decreases.

  • test DatadogCrashReportingTests iOS 28.85% (Δ-0.16%) - Details
  • test DatadogWebViewTrackingTests iOS 22.93% (Δ-0.15%) - Details
  • test DatadogLogsTests tvOS 44.81% (Δ-0.14%) - Details
  • test DatadogLogsTests iOS 44.75% (Δ-0.14%) - Details
  • test DatadogCrashReportingTests tvOS 28.92% (Δ-0.13%) - Details

@maxep maxep merged commit 61ce0cd into develop Jan 24, 2024
@maxep maxep deleted the maxep/RUM-456/privacy-manifest branch January 24, 2024 12:34
@ncreated ncreated mentioned this pull request Jan 25, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Privacy Manifest to Datadog
3 participants