Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4315 feat: Add missing RUM APIs for Objective-C #1853

Merged
merged 2 commits into from
May 21, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented May 20, 2024

What and why?

📦 This PR adds missing RUM APIs for Objective-C SDK.

How?

The list includes:

  • [monitor currentSessionIDWithCompletion:]
  • [monitor stopSession]
  • [monitor addFeatureFlagEvaluationWithName:value:]
  • [monitor setDebug:]

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this May 20, 2024
@ncreated ncreated marked this pull request as ready for review May 20, 2024 14:46
@ncreated ncreated requested review from a team as code owners May 20, 2024 14:46
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 20, 2024

Datadog Report

Branch report: ncreated/RUM-4315/add-missing-objc-apis-for-rum
Commit report: ed9ab00
Test service: dd-sdk-ios

✅ 0 Failed, 2905 Passed, 0 Skipped, 2m 12.6s Total Time
🔻 Test Sessions change in coverage: 4 decreased, 4 increased, 5 no change

🔻 Code Coverage Decreases vs Default Branch (4)

  • test DatadogCrashReportingTests tvOS 27.64% (-0.07%) - Details
  • test DatadogCrashReportingTests iOS 27.61% (-0.05%) - Details
  • test DatadogTraceTests tvOS 55.6% (-0.03%) - Details
  • test DatadogInternalTests tvOS 80% (-0.02%) - Details

Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncreated ncreated merged commit f08878b into develop May 21, 2024
9 checks passed
@ncreated ncreated deleted the ncreated/RUM-4315/add-missing-objc-apis-for-rum branch May 21, 2024 12:06
@ncreated ncreated mentioned this pull request May 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants