Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Mono.Cecil to 0.11.5 #4166

Merged
merged 1 commit into from
May 30, 2023
Merged

Upgrade Mono.Cecil to 0.11.5 #4166

merged 1 commit into from
May 30, 2023

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Upgrade Mono.Cecil to 0.11.5

Reason for change

The new version contains a fix for dotnet/runtime#79477 (comment)

@kevingosse kevingosse requested a review from a team as a code owner May 22, 2023 10:47
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented May 22, 2023 •
edited
Loading

Datadog Report

Branch report: kevin/cecil
Commit report: 004506d

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 274026 Passed, 920 Skipped, 28m 54.5s Wall Time

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4166 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.159
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 877ns 3.28μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces net472 797μs 432ns 1.62μs 0.398 0 0 3.22 KB
#4166 WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 385ns 1.49μs 0 0 0 2.63 KB
#4166 WriteAndFlushEnrichedTraces net472 788μs 298ns 1.15μs 0.396 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody netcoreapp3.1 39.7μs 140ns 525ns 0.0195 0 0 1.63 KB
master AllCycleSimpleBody net472 40.7μs 158ns 613ns 0.261 0 0 1.69 KB
master AllCycleMoreComplexBody netcoreapp3.1 228μs 189ns 731ns 0.114 0 0 9.12 KB
master AllCycleMoreComplexBody net472 237μs 76.8ns 297ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody netcoreapp3.1 169ns 0.0517ns 0.193ns 0.00368 0 0 272 B
master ObjectExtractorSimpleBody net472 146ns 0.156ns 0.583ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.09μs 2.07ns 7.46ns 0.0512 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.08μs 5.46ns 20.4ns 0.619 0.0061 0 3.89 KB
#4166 AllCycleSimpleBody netcoreapp3.1 40.3μs 104ns 389ns 0.0198 0 0 1.63 KB
#4166 AllCycleSimpleBody net472 41.6μs 148ns 572ns 0.266 0 0 1.69 KB
#4166 AllCycleMoreComplexBody netcoreapp3.1 239μs 98.6ns 382ns 0 0 0 9.12 KB
#4166 AllCycleMoreComplexBody net472 241μs 81.8ns 317ns 1.44 0 0 9.28 KB
#4166 ObjectExtractorSimpleBody netcoreapp3.1 169ns 0.0917ns 0.343ns 0.00364 0 0 272 B
#4166 ObjectExtractorSimpleBody net472 146ns 0.121ns 0.47ns 0.0446 0 0 281 B
#4166 ObjectExtractorMoreComplexBody netcoreapp3.1 4.09μs 1.21ns 4.52ns 0.051 0 0 3.78 KB
#4166 ObjectExtractorMoreComplexBody net472 4.02μs 2.86ns 11.1ns 0.617 0.00603 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest netcoreapp3.1 182μs 251ns 971ns 0.181 0 0 20.02 KB
master SendRequest net472 2.16E‑05ns 2.16E‑05ns 7.78E‑05ns 0 0 0 0 b
#4166 SendRequest netcoreapp3.1 186μs 277ns 1.04μs 0.185 0 0 20.02 KB
#4166 SendRequest net472 0.000574ns 0.000217ns 0.000842ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 1.41μs 5.44μs 0.309 0 0 41.72 KB
master WriteAndFlushEnrichedTraces net472 790μs 3.34μs 12.9μs 8.2 2.34 0.391 53.24 KB
#4166 WriteAndFlushEnrichedTraces netcoreapp3.1 632μs 1.07μs 4.16μs 0.322 0 0 41.87 KB
#4166 WriteAndFlushEnrichedTraces net472 786μs 2.72μs 10.2μs 8.25 2.36 0.393 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery netcoreapp3.1 1.16μs 0.818ns 2.95ns 0.00984 0 0 728 B
master ExecuteNonQuery net472 1.42μs 1.82ns 7.03ns 0.11 0.000712 0 690 B
#4166 ExecuteNonQuery netcoreapp3.1 1.19μs 0.465ns 1.8ns 0.00948 0 0 728 B
#4166 ExecuteNonQuery net472 1.35μs 1.18ns 4.57ns 0.11 0.000672 0 690 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch netcoreapp3.1 1.1μs 0.389ns 1.51ns 0.00991 0 0 752 B
master CallElasticsearch net472 2.05μs 0.913ns 3.42ns 0.12 0.00102 0 762 B
master CallElasticsearchAsync netcoreapp3.1 1.25μs 0.317ns 1.23ns 0.0117 0 0 872 B
master CallElasticsearchAsync net472 2.11μs 1.2ns 4.49ns 0.143 0 0 899 B
#4166 CallElasticsearch netcoreapp3.1 1.15μs 0.477ns 1.72ns 0.00982 0 0 752 B
#4166 CallElasticsearch net472 2.11μs 0.911ns 3.53ns 0.12 0.00105 0 762 B
#4166 CallElasticsearchAsync netcoreapp3.1 1.28μs 0.352ns 1.32ns 0.0115 0 0 872 B
#4166 CallElasticsearchAsync net472 2.18μs 1.97ns 7.64ns 0.142 0 0 899 B
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync netcoreapp3.1 1.37μs 1.48ns 5.55ns 0.0133 0 0 992 B
master ExecuteAsync net472 1.61μs 0.278ns 1.04ns 0.152 0.000841 0 963 B
#4166 ExecuteAsync netcoreapp3.1 1.28μs 0.347ns 1.3ns 0.0135 0 0 992 B
#4166 ExecuteAsync net472 1.63μs 0.524ns 1.96ns 0.153 0.000818 0 963 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync netcoreapp3.1 4.21μs 1.01ns 3.65ns 0.0315 0 0 2.36 KB
master SendAsync net472 6.76μs 2.27ns 8.79ns 0.462 0 0 2.92 KB
#4166 SendAsync netcoreapp3.1 4.16μs 1.12ns 4.21ns 0.0312 0 0 2.36 KB
#4166 SendAsync net472 6.75μs 2.21ns 8.26ns 0.464 0 0 2.92 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 2μs 1.22ns 4.39ns 0.0231 0 0 1.72 KB
master EnrichedLog net472 2.53μs 2.42ns 9.38ns 0.286 0 0 1.8 KB
#4166 EnrichedLog netcoreapp3.1 2.02μs 0.738ns 2.66ns 0.0233 0 0 1.72 KB
#4166 EnrichedLog net472 2.49μs 1.71ns 6.4ns 0.284 0 0 1.8 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 119μs 187ns 724ns 0 0 0 4.3 KB
master EnrichedLog net472 150μs 119ns 462ns 0.67 0.223 0 4.64 KB
#4166 EnrichedLog netcoreapp3.1 120μs 140ns 543ns 0 0 0 4.3 KB
#4166 EnrichedLog net472 149μs 54.1ns 210ns 0.67 0.223 0 4.64 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 3.88μs 1.98ns 7.4ns 0.0504 0 0 3.78 KB
master EnrichedLog net472 4.94μs 1.66ns 6.45ns 0.565 0.00247 0 3.57 KB
#4166 EnrichedLog netcoreapp3.1 3.81μs 1.94ns 7.25ns 0.0517 0 0 3.78 KB
#4166 EnrichedLog net472 5.06μs 1.95ns 7.57ns 0.566 0.00252 0 3.57 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive netcoreapp3.1 1.53μs 0.719ns 2.79ns 0.0139 0 0 1.01 KB
master SendReceive net472 1.74μs 0.745ns 2.58ns 0.16 0.000865 0 1.01 KB
#4166 SendReceive netcoreapp3.1 1.5μs 2.3ns 8.61ns 0.0134 0 0 1.01 KB
#4166 SendReceive net472 1.78μs 0.509ns 1.83ns 0.16 0.000902 0 1.01 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 3.72μs 1.31ns 5.08ns 0.0225 0 0 1.67 KB
master EnrichedLog net472 4.22μs 0.944ns 3.4ns 0.35 0 0 2.22 KB
#4166 EnrichedLog netcoreapp3.1 3.72μs 0.904ns 3.38ns 0.0223 0 0 1.67 KB
#4166 EnrichedLog net472 4.29μs 1.31ns 5.09ns 0.351 0 0 2.22 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4166

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.159 773.19 666.90

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan netcoreapp3.1 545ns 0.186ns 0.719ns 0.00731 0 0 544 B
master StartFinishSpan net472 593ns 0.132ns 0.512ns 0.0866 0 0 546 B
master StartFinishScope netcoreapp3.1 773ns 0.241ns 0.932ns 0.00883 0 0 664 B
master StartFinishScope net472 834ns 4.29ns 21ns 0.0992 0 0 626 B
#4166 StartFinishSpan netcoreapp3.1 552ns 0.445ns 1.66ns 0.00728 0 0 544 B
#4166 StartFinishSpan net472 606ns 0.137ns 0.493ns 0.0865 0 0 546 B
#4166 StartFinishScope netcoreapp3.1 667ns 0.207ns 0.774ns 0.00896 0 0 664 B
#4166 StartFinishScope net472 833ns 0.198ns 0.742ns 0.0991 0 0 626 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin netcoreapp3.1 745ns 0.513ns 1.85ns 0.00897 0 0 664 B
master RunOnMethodBegin net472 968ns 0.275ns 1.03ns 0.099 0 0 626 B
#4166 RunOnMethodBegin netcoreapp3.1 776ns 0.223ns 0.833ns 0.00898 0 0 664 B
#4166 RunOnMethodBegin net472 979ns 0.272ns 1.02ns 0.0994 0 0 626 B

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (3,018ms)  : 2902, 3135
     .   : milestone, 3018,
    master - mean (3,001ms)  : 2910, 3093
     .   : milestone, 3001,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (3,750ms)  : 3664, 3836
     .   : milestone, 3750,
    master - mean (3,750ms)  : 3666, 3835
     .   : milestone, 3750,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (3,138ms)  : 2996, 3280
     .   : milestone, 3138,
    master - mean (3,141ms)  : 3040, 3242
     .   : milestone, 3141,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (3,583ms)  : 3515, 3651
     .   : milestone, 3583,
    master - mean (3,589ms)  : 3530, 3647
     .   : milestone, 3589,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (3,119ms)  : 2990, 3249
     .   : milestone, 3119,
    master - mean (3,117ms)  : 2977, 3256
     .   : milestone, 3117,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (3,567ms)  : 3507, 3626
     .   : milestone, 3567,
    master - mean (3,553ms)  : 3507, 3600
     .   : milestone, 3553,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (187ms)  : 185, 190
     .   : milestone, 187,
    master - mean (188ms)  : 183, 193
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (1,037ms)  : 1008, 1066
     .   : milestone, 1037,
    master - mean (1,030ms)  : 1008, 1053
     .   : milestone, 1030,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (370ms)  : 363, 377
     .   : milestone, 370,
    master - mean (366ms)  : 362, 371
     .   : milestone, 366,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (1,135ms)  : 1102, 1168
     .   : milestone, 1135,
    master - mean (1,133ms)  : 1102, 1164
     .   : milestone, 1133,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4166) - mean (357ms)  : 353, 361
     .   : milestone, 357,
    master - mean (357ms)  : 349, 365
     .   : milestone, 357,

    section CallTarget+Inlining+NGEN
    This PR (4166) - mean (1,095ms)  : 1068, 1122
     .   : milestone, 1095,
    master - mean (1,094ms)  : 1070, 1119
     .   : milestone, 1094,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4166) (11.495M)   : 0, 11494704
    master (11.477M)   : 0, 11477044
    benchmarks/2.30.0 (11.549M)   : 0, 11549426
    benchmarks/2.9.0 (11.162M)   : 0, 11161538

    section Automatic
    This PR (4166) (8.121M)   : 0, 8121247
    master (8.147M)   : 0, 8147253
    benchmarks/2.30.0 (8.010M)   : 0, 8010181
    benchmarks/2.9.0 (8.099M)   : 0, 8099075

    section Trace stats
    master (8.140M)   : 0, 8139776
    benchmarks/2.30.0 (8.081M)   : 0, 8080511

    section Manual
    This PR (4166) (10.344M)   : 0, 10344456
    master (10.349M)   : 0, 10348616
    benchmarks/2.30.0 (10.189M)   : 0, 10189167

    section Manual + Automatic
    This PR (4166) (7.833M)   : 0, 7833087
    master (7.835M)   : 0, 7834984
    benchmarks/2.30.0 (7.643M)   : 0, 7643037

    section Version Conflict
    master (7.130M)   : 0, 7130423
    benchmarks/2.30.0 (7.013M)   : 0, 7012856
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4166) (9.395M)   : 0, 9395305
    master (9.588M)   : 0, 9587503
    benchmarks/2.30.0 (9.714M)   : 0, 9713675
    benchmarks/2.9.0 (9.705M)   : 0, 9704781

    section Automatic
    This PR (4166) (6.804M)   : 0, 6804479
    master (6.866M)   : 0, 6865558
    benchmarks/2.30.0 (6.898M)   : 0, 6897764

    section Trace stats
    master (6.937M)   : 0, 6936541
    benchmarks/2.30.0 (6.838M)   : 0, 6838296

    section Manual
    This PR (4166) (8.602M)   : 0, 8601800
    master (8.363M)   : 0, 8363043
    benchmarks/2.30.0 (8.478M)   : 0, 8477595

    section Manual + Automatic
    This PR (4166) (6.729M)   : 0, 6729185
    master (6.578M)   : 0, 6578464
    benchmarks/2.30.0 (6.599M)   : 0, 6598911

    section Version Conflict
    master (5.862M)   : 0, 5861650
    benchmarks/2.30.0 (5.907M)   : 0, 5907125
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4166) (10.314M)   : 0, 10313733
    master (10.228M)   : 0, 10228469
    benchmarks/2.30.0 (10.297M)   : 0, 10296694
    benchmarks/2.9.0 (9.827M)   : 0, 9827121

    section Automatic
    This PR (4166) (7.249M)   : 0, 7248660
    master (7.628M)   : 0, 7627746
    benchmarks/2.30.0 (7.637M)   : 0, 7637276
    benchmarks/2.9.0 (7.246M)   : 0, 7246397

    section Trace stats
    master (7.595M)   : 0, 7595213
    benchmarks/2.30.0 (7.417M)   : 0, 7416655

    section Manual
    This PR (4166) (9.349M)   : 0, 9348528
    master (9.134M)   : 0, 9133683
    benchmarks/2.30.0 (9.202M)   : 0, 9201881

    section Manual + Automatic
    This PR (4166) (7.361M)   : 0, 7361019
    master (7.337M)   : 0, 7336632
    benchmarks/2.30.0 (7.265M)   : 0, 7264832

    section Version Conflict
    master (6.739M)   : 0, 6739127
    benchmarks/2.30.0 (6.414M)   : 0, 6414175
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4166) (7.446M)   : 0, 7445622
    master (7.419M)   : 0, 7418887
    benchmarks/2.30.0 (7.541M)   : 0, 7540956
    benchmarks/2.9.0 (7.748M)   : 0, 7748029

    section No attack
    This PR (4166) (2.410M)   : 0, 2409986
    master (2.412M)   : 0, 2411927
    benchmarks/2.30.0 (2.402M)   : 0, 2401977
    benchmarks/2.9.0 (3.274M)   : 0, 3273699

    section Attack
    This PR (4166) (2.004M)   : 0, 2003660
    master (2.050M)   : 0, 2049766
    benchmarks/2.30.0 (2.063M)   : 0, 2062907
    benchmarks/2.9.0 (2.598M)   : 0, 2597950

    section Blocking
    This PR (4166) (4.104M)   : 0, 4104038
    master (4.127M)   : 0, 4126980
    benchmarks/2.30.0 (4.097M)   : 0, 4096940
Loading

@kevingosse kevingosse merged commit c084b73 into master May 30, 2023
@kevingosse kevingosse deleted the kevin/cecil branch May 30, 2023 09:08
@github-actions github-actions bot added this to the vNext milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kevingosse @andrewlock