Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVIEW-FIX #61

Merged
merged 1 commit into from
Apr 16, 2020
Merged

REVIEW-FIX #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions src/Plugins/PhpCodeSnifferJsonResultsParser/PhpCodeSnifferJsonResultsParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,16 @@
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\ResultsParser;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayParseException;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayUtils;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\FqcnRemover;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\JsonParseException;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\JsonUtils;
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ParseAtLocationException;

/**
* Handles PHPStan's JSON output.
*
* NOTE: SARB only deals with errors that are attached to a particular line in a file.
* PHPStan can report general errors (not specific to file). These are ignored by SARB.
* Handles PHP Code Sniffers's JSON output.
*/
class PhpCodeSnifferJsonResultsParser implements ResultsParser
{
private const LINE = 'line';
private const TYPE = 'type';
private const SOURCE = 'source';
private const FILES = 'files';
private const MESSAGES = 'messages';
Expand All @@ -48,19 +43,6 @@ class PhpCodeSnifferJsonResultsParser implements ResultsParser
private const ERRORS = 'errors';
private const WARNINGS = 'warnings';

/**
* @var FqcnRemover
*/
private $fqcnRemover;

/**
* PhpstanJsonResultsParser constructor.
*/
public function __construct(FqcnRemover $fqcnRemover)
{
$this->fqcnRemover = $fqcnRemover;
}

/**
* {@inheritdoc}
*/
Expand Down Expand Up @@ -236,7 +218,6 @@ private function convertAnalysisResultFromArray(
): AnalysisResult {
$lineAsInt = ArrayUtils::getIntValue($analysisResultAsArray, self::LINE);
$rawMessage = ArrayUtils::getStringValue($analysisResultAsArray, self::MESSAGE);
$rawType = ArrayUtils::getStringValue($analysisResultAsArray, self::TYPE);
$rawSource = ArrayUtils::getStringValue($analysisResultAsArray, self::SOURCE);

$location = new Location(
Expand Down