PR to 9fc93a4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 27, 2019 10:57
put all validators behind a single module name
unboxing it fixed our lifetime problems
and it looks SO MUCH NICER dont you think??
one less clone is good
cant support these till we make an allocation protocol
and eliminate a ton of clones as a result
miscellaneous lint fixes in `Instance`
This prevents resources like embedder contexts or heap views from living across yield points, which is important for safety since the host can modify the data underlying those resources while the instance is suspended. Since this is a semver breaking change, this patch also updates the package versions.
Make yield methods take `&mut Vmctx`; update semver
Fixes #276 - Allow use of aligned heaps
add blank rustfmt config file
This was previously accepted by the compiler but is being phased out; it will become a hard error in a future rustc release. See rust-lang/rust#66145 >
The benchmark and fuzz targets in particular take quite a long time to run, and are usually not the focus of development. They're still worth running in CI, though, to catch bitrot.
Switch back to stable, make local `make test` target cheaper
clean up `symbol_data` control flow
move lucet-module bindings tests
* Addresses two lint warnings about redundant field names, using the shorthand notation instead. * Moves `*_name_for` helper functions nested inside of `declare_funcs` out of a loop body. This is just a small readability fix for our loop.
Currently, `lucetc` assumes that the machine that it's compiling
for (the "target") is the same as the machine on which `lucetc` is
running ("the host"). While this is a reasonable assumption to make,
many future uses of `lucetc` may require these machines to be distinct.
Towards that end, let's introduce a `--target` option for specifying the
machine `lucetc` is supposed to be generating code for, and thread that
information through to all the places that require it.
It was already possible to use via the `Instance::kill_switch()` method, but couldn't be named in a type signature or a type declaration.
Export the `KillSwitch` type from the public runtime API
replace empty constructor w/ default impl
add optional target specification to CpuFeatures
Co-authored-by: Pat Hickey <[email protected]>
Most of our thinking about semver for this project is concerned with the more "public-facing" crates like `lucetc`, `lucet-runtime`, and `lucet-wasi`, as opposed to "implementation detail" crates like `lucet-module`, `lucet-runtime-internals`, etc. As the project matures, we are paying more attention to semver for all of the crates, but this change makes the released sets of packages more consistent.
Use exact dependencies for crates within the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.