Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --check-format flag and improve help texts #41

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

matze
Copy link
Contributor

@matze matze commented Jul 11, 2022

No description provided.

matze added 2 commits July 11, 2022 15:34
If set, `cargo-sort` will also return a non-zero exit code if formatting
changes. This also allows to drop the explicit setting of the
`no-format` option in case `check` is enabled.
Copy link
Owner

@DevinR528 DevinR528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look great! Just lowercase, and I can merge. Sorry, this has taken me so long.

@DevinR528 DevinR528 changed the title Fix #40 and improve help texts Add --check-format flag and improve help texts Jul 25, 2022
@DevinR528
Copy link
Owner

As long as you are ready to merge I'm happy with this.

Resolves #40

@DevinR528 DevinR528 linked an issue Jul 25, 2022 that may be closed by this pull request
@matze
Copy link
Contributor Author

matze commented Jul 25, 2022

As long as you are ready to merge I'm happy with this.

Yes from my side it's ready. And thanks for the taking the time and considering the feature! Certainly makes my life easier :-)

@DevinR528 DevinR528 merged commit c29e63f into DevinR528:main Oct 7, 2022
@DevinR528
Copy link
Owner

Again sorry this took so long @matze

@matze matze deleted the fix-40-check-format branch October 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let -c or some new flag take formatting into consideration
2 participants