Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1646: Show 'Use Facility Account' button for EU dewar dispatch #910

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1646

Summary:

European users should be allowed to request dewar dispatch via Synchweb, an request to use our account. This won't go via the shipping service so it will be reviewed anyway. At the moment, the "Use Facility Account" button is only shown to UK users, we should enable it for European users as well.

Changes:

  • Show button if EU as well as if UK

To test:

  • Set this in config.php:
$facility_courier_countries_nde = array('Austria', 'Belgium', 'Bulgaria', 'Croatia', 'Cyprus', 'Czech Republic, The', 'Denmark', 'Estonia', 'Finland', 'France', 'Germany', 'Greece', 'Hungary', 'Iceland', 'Ireland, Republic Of', 'Italy', 'Latvia', 'Liechtenstein', 'Lithuania', 'Luxembourg', 'Malta', 'Netherlands, The', 'Norway',  'Poland', 'Portugal', 'Romania', 'Slovakia', 'Slovenia', 'Spain', 'Sweden');
  • Go to a dewar where the shipping terms have not yet been accepted eg /shipments/sid/66700
  • Click Dispatch
  • Set the laboratory country to United Kingdom, check the 'Use Facility Account button is shown
  • Change the laboratory country to Afghanistan, check the button disappears
  • Change the laboratory country to France, check the button re-appears
  • Click the button, check the Courier Details section of the form changes to say it will be paid for by the facility
  • Complete the rest of the form and click "Request Dewar Dispatch", check there are no errors and the dewar status changes to dispatch-requested.

@gfrn gfrn self-requested a review March 3, 2025 13:27
@gfrn gfrn added the Configuration Change Pull requests which necessitate changes to SynchWeb configuration label Mar 3, 2025
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R2.1 March 11, 2025 14:22
@ndg63276 ndg63276 merged commit 435c070 into pre-release/2025-R2.1 Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Change Pull requests which necessitate changes to SynchWeb configuration Ready to Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants