Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1632: Buttons to go to next & previous puck in dewar #912

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RichB-DLS
Copy link
Collaborator

@RichB-DLS RichB-DLS commented Feb 28, 2025

JIRA ticket: LIMS-1632

Summary:
Provides a new component with prev/next button links to access the next & Previous containers in the Dewar when viewing a container.

Changes:

  • Added new page-title-header & prev-next-btgroup vue components which can display the prev/next puck in the header if target data supplied. Dumb components for the most part due to page reloads being default behaviour.
  • mx-container-view.vue collates sibling containers using existing containersCollection (if exists) or by fetching the collection as required.

To test:

  • Visit a shipment page containing a Dewar with multiple containers eg /shipments/sid/69283. note the order of the containers within the Dewar.
  • Click through to a container of the Dewar - noting it's position in the list.
  • In the container page, use the prev / next buttons to move between containers in the Dewar confirming the order matches that previously shown at the shipping level. On the first item the "Prev" button should be disabled. On the last item the "Next" button should be disabled.
  • Visit a shipment with 1 container eg containers/cid/326821, bothe Next & Prev buttons should show as disabled.

Further Steps

  • This prev-next-btgroup component could then be used further to provide similar functionality for shipments etc.
  • see LIMS-1683 for further expansion

@RichB-DLS RichB-DLS added enhancement javascript Pull requests that update Javascript code labels Feb 28, 2025
@RichB-DLS RichB-DLS requested review from gfrn and ndg63276 February 28, 2025 10:16
@RichB-DLS RichB-DLS changed the title Improvement/lims 1632/buttons to go to next puck and previous puck in dewar LIMS-1632/buttons to go to next puck and previous puck in dewar Feb 28, 2025
@RichB-DLS RichB-DLS changed the title LIMS-1632/buttons to go to next puck and previous puck in dewar LIMS-1632: Buttons to go to next puck and previous puck in dewar Feb 28, 2025
@RichB-DLS RichB-DLS changed the title LIMS-1632: Buttons to go to next puck and previous puck in dewar LIMS-1632: Buttons to go to next & previous puck in dewar Feb 28, 2025
@RichB-DLS RichB-DLS marked this pull request as draft March 10, 2025 13:17
@RichB-DLS RichB-DLS marked this pull request as ready for review March 10, 2025 14:31
@RichB-DLS RichB-DLS requested a review from ndg63276 March 14, 2025 08:17
Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants