Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-995: Fix Shipment Stats page #915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-995

Summary:

The shipment stats at https://ispyb.diamond.ac.uk/shipments/stats timeout after 1 minute. The slow joins are to BLSample and DataCollection, which are only needed if the 'With Data' tickbox is turned on.

Changes:

  • Remove 'With Data' checkbox and associated code
  • Remove joins to BLSample and DataCollection
  • Remove non-functional search boxes

To test:

  • Go to /shipments/stats, check the page loads, with a graph and 2 tables
  • Check there is no 'With Data' checkbox, and no search boxes on any tables
  • Check the 'With Dewar History' checkbox still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant