-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mock module and move tests #47
Conversation
Ideally the tests would be separate from the main module(s) so that they wouldn't be present in the application. Due to these complications maybe it is easier to move the tests as you have done but I might ask for a second opinion. I think it might also be good to wait until we can get the CI running again (#46) to verify the tests can still all run as expected. |
@isikhar do you have any objections to this being merged? I would still like to check that we can still run the tests before merging. |
We should merge #46 first, then fix-up this so that the tests pass. |
@joeshannon and @isikhar, this ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think Irakli was previously happy with these changes.
These changes are fine with me as well. |
Is the CI known to be broken? |
No I don't think so. Not sure why it's not running. I see that it run for your fork. I'm not hugely familiar with GH actions, we currently have
Does that seem correct? |
So it did (see https://github.com/DominicOram/diffcalc/actions/runs/3338486618/jobs/5526204223). Yes, those actions seem correct to me. Are we happy to chalk it up to GH weirdness and get I'll merge this? |
Fixes #45
To test:
mock
andtest
being moved out of top level