Added icons for RC3 and RC4

[saltedlolly]

Quickly did these by editing the existing logo file. We could replace rc3 logo and replace the release. At least then people know what version they are running.

[ghost]

Good work @saltedlolly !

[ycagel]

ACK.

[ghost]

ACK.

[JaredTate]

ACK. Compiles, runs & looks great! Thanks for doing this and thinking ahead with RC4. I canceled my Adobe membership last fall to save some $$, so I don't have an easy way to edit these.

[JaredTate]

ACK.

Looks like you need to hit the "review changes" in the upper right-hand corner to "approve" so it provides a 3rd check mark approval. Thanks for helping with reviews & all your work!

[ghost]

i did but my check is not the same color ^^

Update: now its blue! ty

[JaredTate]

i did but my check is not the same color ^^

Update: now its blue! ty

It should work now, there was a permissions issue in the organization. Cheers

[saltedlolly]

@Jongjan88 and myself are only reviewers so our approvals never count towards one of the three required approvals. I am okay with that as I am not a C++ dev (though I would not approve anything I don't understand). On the other hand Jan is a C++ dev so he IS qualified to review changes, if and when the core devs want to allow him that responsibility.

[JaredTate]

@Jongjan88 and myself are only reviewers so our approvals never count towards one of the three required approvals. I am okay with that as I am not a C++ dev (though I would not approve anything I don't understand). On the other hand Jan is a C++ dev so he IS qualified to review changes, if and when the core devs want to allow him that responsibility.

He should be good to go now, and I have no problem adding you as a full reviewer either. You have contributed a ton and are very active. I will ask the other guys what they think. It would be great to have more reviewers for continuous development.

[saltedlolly]

@JaredTate I was trying to figure out how to help fix the build process to ensure the filenames and folder names are correct, as previously discussed. Is it in this repo, or somewhere else? https://github.com/DigiByte-Core/DigiByte-GUIX-Docker

[JaredTate]

That is for the docker container, not the actual GUIX build process. I think the code for filenames is here, but not 100% sure where the folder names are drawn from in GUIX code. The file names change again after the complete formal signing process. Part of the signing process for a formal release includes the commit hash in the filename/folder to verify the commit the binaries are compiled from.

digibyte/contrib/guix/guix-build

Lines 315 to 329 in 3c77dec

	# Usage: outdir_for_host HOST SUFFIX
	#
	# HOST: The current platform triple we're building for
	#
	outdir_for_host() {
	echo "${OUTDIR_BASE}/${1}${2:+-${2}}"
	}
	# Usage: profiledir_for_host HOST SUFFIX
	#
	# HOST: The current platform triple we're building for
	#
	profiledir_for_host() {
	echo "${PROFILES_BASE}/${1}${2:+-${2}}"
	}