-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make check #175
Fix: Make check #175
Conversation
@Jongjan88 , thank you so much for your continued help with resolving the test failures. I left some comments but now that I see you put the PR in draft form those comments may be moot. Feel free to just dismiss my comments if you are still working on the tests. |
Thanks for starting on this, I see you commented several out, I assume you will go back on these? I will start in tonight/ tomorrow on some tests. We cold coordinate an attack plan. I see this is draft status. |
Of course. I wanted to share what I found so far. And make it a little easier for others. I'll start working on it tomorrow. |
Make check without errors. Running > 95% of the tests.
Needs PR174