Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1st 5 Functional Tests #183

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix 1st 5 Functional Tests #183

merged 3 commits into from
Mar 5, 2024

Conversation

JaredTate
Copy link

@JaredTate JaredTate commented Mar 5, 2024 •
edited
Loading

This PR fixes the first 5 functional tests. I am splitting this up so it does not get super unwieldy to review for fixing all the tests. Many changes are changing COINBASE_MATURITY_ORIGINAL to COINBASE_MATURITY_2 to match core protocol terminology.

To test this do:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Functional Tests

test/functional/test_runner.py

Should pass first 5 & fail on 6th test:

Screenshot 2024-03-05 at 11 58 23 AM

@ycagel ycagel requested review from SmartArray, digicontributer, gto90, j50ng, a user and ycagel March 5, 2024 19:33
ghost
ghost suggested changes Mar 5, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaredTate Thank you for the pr. Nice work.

@ghost ghost closed this Mar 5, 2024
@JaredTate JaredTate reopened this Mar 5, 2024
@JaredTate
Copy link
Author

lol

@ghost
Copy link

ghost commented Mar 5, 2024

lol

sorry!! I did gh pr close.

@JaredTate
Copy link
Author

lol

sorry!! I did gh pr close.

It's all good! Thanks for your help! :)

gto90
gto90 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thank you @JaredTate

ycagel
ycagel approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks for the efforts @JaredTate!

@ycagel ycagel merged commit e0ed879 into DigiByte-Core:develop Mar 5, 2024
@beggsdl
Copy link

beggsdl commented Mar 6, 2024

Nice work @JaredTate. I was glad to see you got rid of COINBASE_MATURITY_ORIGINAL and used COINBASE_MATURITY_2 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaredTate @beggsdl @ycagel @gto90