Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 10 Functional Tests #184

Merged
merged 8 commits into from Mar 6, 2024
Merged

Fix 10 Functional Tests #184

merged 8 commits into from Mar 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2024

Compile:

./autogen.sh
./configure
make -j 8

test/functional/test_runner.py --jobs=8

OR

python rpc_net.py
python wallet_fallbackfee.py --descriptors
python wallet_fallbackfee.py --descriptors
python wallet_labels.py --descriptors
python wallet_labels.py --legacy-wallet
python wallet_listsinceblock.py --descriptors
python wallet_listsinceblock.py --legacy-wallet
python wallet_watchonly.py --legacy-wallet
python wallet_watchonly.py --usecli --legacy-wallet
python wallet_descriptor.py --descriptors

gto90
gto90 previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thank you @Jongjan88

@JaredTate
Copy link

So looks like test/functional/test_runner.py rpc_net.py still fails for me:
Screenshot 2024-03-06 at 10 39 12 AM

@ghost ghost dismissed gto90’s stale review via 23f2940 March 6, 2024 17:44
@ghost
Copy link
Author

ghost commented Mar 6, 2024 •
edited by ghost
Loading

Screenshot from 2024-03-06 18-45-23

fixed

@ghost ghost requested a review from gto90 March 6, 2024 17:46
JaredTate
JaredTate approved these changes Mar 6, 2024
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Sweet, they all pass for me now, looks good, the wallet compiles and runs. Great work!

ycagel
ycagel approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

gto90
gto90 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gto90 gto90 merged commit e6bb518 into DigiByte-Core:develop Mar 6, 2024
@ghost ghost deleted the python branch March 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaredTate @ycagel @gto90