Disable Benchmarks For Default Compiling & Make Check #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycagel
requested review from
SmartArray,
ycagel,
digicontributer,
gto90,
j50ng and
a user
|
make check only got one errors left after this pr. Line: 88 |
Are you on the latest updated branch? I can't replicate that error at all. |
|
100% did new pull and add this pr. Plus build with new depends. Maybe because different compiler. We can approve this pr and look at it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables compiling the benchmarks by default so that when we run
make checkall unit, wallet & GUI tests now pass successfully. It also fixes the first bench test error I came across.Benchmarks can still be run by configuring with
./configure --enable-benchflag. I started attempting to fix the bench files but I don't think it's a good use of time right now. These are just non-essential tests at the moment.You can read more about benchmarks here:
https://github.com/JaredTate/digibyte/blob/develop/doc/benchmarking.md
The reality is they are performance benchmarks to gauge the code, which could be useful one day, but I think we have other priorities. A lot of the existing benchmark code would need to be rewritten for DGB's 5 algos. The BTC devs never even finished all the benchmarks for BTC.
What really matters when we
make checkare the qt GUI tests, wallet tests, and all the 470 unit test cases. Which now all pass withmake check