Update test_runner.py & Disable 3 Taproot tests #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycagel
requested review from
SmartArray,
ycagel,
digicontributer,
gto90,
j50ng and
a user
ghost
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables 3 taproot functional tests in test_runner.py. The tests can be re-enabled once we determine the path forward and plan for taproot in the future. Right now since we had set taproot deployment for indefinite time in future tests can't be properly configured.
In the interest of time & getting a RC4 out with all tests passing I think it's best to disable these tests for the time being until the exact taproot deployment configuration is determined.