Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 6 remaining functional tests that had recently been broken with changes. Fixes in: wallet_create_tx.py, wallet_importdescriptors.py, wallet_bumpfee.py, wallet_basic.py.
wallet_bumpfee.py: As replace by fee was disabled in DGB GUI, part of bumpfee was disabled on core protocol but most of the bump fee code is still active in core protocol, it just cannot be accessed in GUI. With that I could not get one section of bumpfee tests to work because of disabled code.
Wallet_basic.py: At very end of test a legacy-wallet bypass was added for the abandon transaction test for legacy-wallet. Descriptors wallet working as expected. For whatever reason it already gets added to mempool and no tx to abandon for rawmempool. This needs to be sorted with dandelion and mempool behavior. Next step would be getting the dandelion python test working for the first time ever. This may be a side effect of having dandelion as well, I am not sure. We need to test dandelion with descriptor wallets as well.
To test this:
Compile:
Run Specific Functional Tests