Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Qt wallet logo #279

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Conversation

gto90
Copy link
Member

@gto90 gto90 commented Jan 25, 2025

This PR updates the Qt wallet logos.

JaredTate and others added 5 commits January 20, 2025 11:30
CBlockIndex's constructor only sets lastAlgoBlocks[this->GetAlgo()] = this; and leaves other array entries at nullptr, but we need them to mirror the parent's array.

That logic allows GetLastBlockIndexForAlgoFast() to jump from block to block for a given algo without hitting uninitialized pointers.

Debugged this with ASAN after seeing:
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior pow.cpp:354:21 in
chain.h:263:9: runtime error: member call on misaligned address 0xbebebebebebebebe for type 'const CBlockIndex *', which requires 8 byte alignment
@gto90 gto90 self-assigned this Jan 25, 2025
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK! Thank you for doing this!

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Appreciate it @gto90!

@ycagel ycagel merged commit 074fd08 into develop Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants