Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic deployment maintenance #68

Merged

Conversation

barrystyle
Copy link

Buried deployments are given a negative value instead of a standard deployment's positive value, which causes a segfault on launch when specified in chainparams.cpp

         correcting ranges in consensus/params.h
@barrystyle
Copy link
Author

image

chainparams.cpp:114:57: warning: array subscript -32761 is below array bounds of ‘Consensus::BIP9Deployment [2]’ [-Warray-bounds]

@JaredTate
Copy link

ACK Looks good! Appreciate your help, this makes sense.

@JaredTate JaredTate merged commit 21e9928 into DigiByte-Core:feature/8.22.0 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants